Sensor test asserts when run with no sensors connected

[dave]

** Assertion **
sensors.c:59
(sensors_mode[ser
Assertion failed

Without looking at the source, it appears that the sensor test is attempting to poll sensors before initializing them. In any case, the sensor driver is being accessed with an uninitialized sensor. Not good.

[sam]

A possible code path leading to this assertion :

tests_usb()
  tests_sensors()
  tests_radar()

tests_sensors() will enable all sensor ports in analog, but not disable them. tests_radar() will try to enable in I2C mode the port 0, and will thus fail because sensors_mode[0] != OFF.

[sam]

Note that I still have no idea why the assertion would popup by itself "after a while".

[sam]

Replying to sam:

Note that I still have no idea why the assertion would popup by itself "after a while".

A similar code path is followed by the tests_all() function, where tests_sensors() is called before tests_radar(). I adding the relevant calls to disable the sensors at the end of tests_sensors().

[sam]

Code submitted, requires testing.

[dave]

The change in question is 7ccf88f7afaa , and a few changes preceding it. Looks good to me, merged into devel.